You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 10 Next »

Explanation

This rule analyses all expressions and determines whether they are complex by the following criteria:

  • more than five AND or OR logical operators
  • more than two nested COLLECT statements

We estimate that resolving this issue will on average take 30 minutes.

Possible improvement

Try to split up some part of the expression, either as reusable expression, in an intermediate attribute or in an local variable. If this is not possible make sure to put comments in the expression explaining what is happening.

Example

This expression is considered too complex (and unnecessarily complex as well, because the desired result could simply be achieved by SUM( COLLECT Person.PersonalPremium FROM ALL Person )! )

It results in this code smell:

 

  • No labels