BMA rule: Flow contains incorrect condition node

Created by Roy Bissels, last modified on Mar 10, 2022

Explanation

This rule detects if the condition in a condition node contains logical or equality operators, or results in a constant value.

We estimate that resolving this issue will on average take 5 minutes.

Possible improvement

The condition should not contain any operators, the different possible outcomes should be checked in the alternatives.
When the condition of a condition node is constant, the use of a condition node doesn't make sense.

Example

This flow contains a condition node where no label is present. It is unclear what kind of decision is represented by the node.

This is an example of how it should not be done.

Move the value check to the alternatives, so the condition doesn't contain any operators anymore.

This flow results in the following code smell:

bma41